Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbcCRXCG (ORCPT ); Fri, 18 Mar 2016 19:02:06 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:35520 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbcCRXBx (ORCPT ); Fri, 18 Mar 2016 19:01:53 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160317000918.GA12818@kroah.com> Date: Fri, 18 Mar 2016 16:01:51 -0700 X-Google-Sender-Auth: ZXDxBShzxBn63JpXOk7XAnVtNu0 Message-ID: Subject: Re: [GIT PULL] USB driver patches for 4.6-rc1 From: Linus Torvalds To: Greg KH , Peter Chen , Philipp Zabel , Alan Stern , Rob Herring , Arnd Bergmann Cc: Andrew Morton , Linux Kernel Mailing List , USB list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 18 On Fri, Mar 18, 2016 at 3:51 PM, Linus Torvalds wrote: > > The commit that ends up being marked bad is odd, but there it is: > 69bec7259853 "USB: core: let USB device know device node". Confirmed. Not only did it bisect to that, reverting it on top of the current kernel fixes my machine. So that commit is somehow buggy. I don't see what it does that would break even with OF disabled, but something does. I'll just revert it. The way it is done seems bogus anyway. It looks at of_node when OF is disabled, but generally that isn't even initialized as far as I can tell, and we have things like dev_of_node() helpers to make sure you don't do that. Linus