Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbcCRXFQ (ORCPT ); Fri, 18 Mar 2016 19:05:16 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59309 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753108AbcCRXFE (ORCPT ); Fri, 18 Mar 2016 19:05:04 -0400 Date: Sat, 19 Mar 2016 00:05:01 +0100 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , Oleksij Rempel , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: asm9260: remove incorrect __init/__exit annotations Message-ID: <20160318230501.GD2828@piout.net> References: <1458078287-586232-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458078287-586232-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 26 On 15/03/2016 at 22:44:31 +0100, Arnd Bergmann wrote : > The probe and remove callbacks of the platform driver are marked __init > and __exit, respectively. However, this is not a correct way to annotate > them, as it will result in those sections to be discarded at link time > or after boot, while we can actually call them again based on manual > unbinding, or deferred probing. > > Kbuild warns about the problem: > > WARNING: drivers/rtc/rtc-asm9260.o(.data+0x0): Section mismatch in reference from the variable asm9260_rtc_driver to the function .init.text:asm9260_rtc_probe() > > This removes the annotations, so we no longer branch into missing > code and avoid the warning. > > Signed-off-by: Arnd Bergmann > Fixes: 125e550fd257 ("rtc: add Alphascale asm9260 driver") > --- > drivers/rtc/rtc-asm9260.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com