Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605AbcCSKB4 (ORCPT ); Sat, 19 Mar 2016 06:01:56 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:42217 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbcCSKBu convert rfc822-to-8bit (ORCPT ); Sat, 19 Mar 2016 06:01:50 -0400 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mason Cc: Uwe Kleine-Koenig , Sebastian Frias , Daniel Mack , "David S. Miller" , netdev@vger.kernel.org, lkml , Florian Fainelli , Fabio Estevam , Martin Blumenstingl , Linus Walleij Subject: Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB References: <56E99727.9040702@laposte.net> <20160318125455.GN4292@pengutronix.de> <56EC2525.8000706@laposte.net> <20160318191242.GQ4292@pengutronix.de> <56EC5788.3030509@free.fr> <20160318201153.GR4292@pengutronix.de> <56EC68A5.3050901@free.fr> Date: Sat, 19 Mar 2016 10:01:44 +0000 In-Reply-To: <56EC68A5.3050901@free.fr> (Mason's message of "Fri, 18 Mar 2016 21:44:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 36 Mason writes: > On 18/03/2016 21:11, Uwe Kleine-K?nig wrote: > >> Hello, >> >> On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote: >> >>> On 18/03/2016 20:12, Uwe Kleine-K?nig wrote: >>> >>>> On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: >>>> >>>>> What would you think of making at803x_link_change_notify() print a >>>>> message every time it should do a reset but does not has a way to do it? >>>> >>>> Then this question is obsolete because the device doesn't probe. >>> >>> I don't understand this statement. >>> >>> What does it mean for a question to be obsolete? >> >> If the driver doesn't probe because it cannot control the reset line, >> you don't need to think about how it should behave in >> at803x_link_change_notify without control of the reset line, because >> this code isn't reached then. > > If I understand correctly, it is possible to soft-reset the PHY > by writing to a specific register. The GPIO pin is useful only to > force a hardware-reset when the PHY is wedged by some random event. Yes, and some variants of this phy are broken and require a hard reset in certain situations. At least that's what the comment in the code says. -- M?ns Rullg?rd