Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224AbcCSLMe (ORCPT ); Sat, 19 Mar 2016 07:12:34 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:23908 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbcCSLMd (ORCPT ); Sat, 19 Mar 2016 07:12:33 -0400 Subject: Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support To: Jiri Pirko , , , , , , , , , , , , , , , , , , , References: <1457692631-9290-1-git-send-email-oulijun@huawei.com> <1457692631-9290-2-git-send-email-oulijun@huawei.com> <20160311104239.GD3931@nanopsycho.orion> <56E9340E.3040207@huawei.com> <20160316103638.GB2254@nanopsycho.orion> <20160317064359.GA25216@leon.nu> From: oulijun Message-ID: <56ED33ED.5050800@huawei.com> Date: Sat, 19 Mar 2016 19:11:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160317064359.GA25216@leon.nu> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.25.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.56ED33FA.00C7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 45e2314fca178e6d2f59eec5606b9c1f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 36 On 2016/3/17 14:43, Leon Romanovsky wrote: > On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: >>> so, I continue to have it. >> >> I will continue to bash on your odd codingstyle. Please fix it! > > Jiri, > > Checkpatch errors is an easiest issue with this patch. > > It is full of functions without use, unconnected macros and > if you replace "hsi" to name of other well known driver, you will get > same code :). > > They need to redesign the whole driver before resubmission. > > Thanks. > > . > Hi, Leon Romanovsky Firstly, thanks for reviewing. I have checked the patch v2, surely, some funtions without use and unconnected macros exist. I have removed it according to analyse. I will leave few marcos as follow: #define CQ_STATE_INVALID 0 #define CQ_STATE_RESERV 1 #define CQ_STATE_VALID 2 #define CQ_STATE_ERR 3 I thought that these are defined for hardware information. So, I reserved these macros. In addtion, I didn't completly understand your review as below: if you replace "hsi" to name of other well known driver, you will get > same code :). thanks Lijun Ou