Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754506AbcCSLOd (ORCPT ); Sat, 19 Mar 2016 07:14:33 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:24215 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319AbcCSLOZ (ORCPT ); Sat, 19 Mar 2016 07:14:25 -0400 Subject: Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support To: , , , , , , , , , , , , , , , , , , References: <1457692631-9290-1-git-send-email-oulijun@huawei.com> <20160312102051.GC11383@leon.nu> From: oulijun Message-ID: <56ED3477.2050307@huawei.com> Date: Sat, 19 Mar 2016 19:13:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160312102051.GC11383@leon.nu> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.25.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.56ED3484.010F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: dabea78a2372e2ec843adf4d6f8a0037 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 42 On 2016/3/12 18:20, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:08PM +0800, Lijun Ou wrote: > > 1) It is redundant to write "infiniband" and "IB" in one title to mention > relevant subsystem, since it is the same. > > Please take a look on the other submissions here on the list and use > similar construction. > > 2) Please use version number in the titles [PATCH vXXX] > Hi dledford, thanks for reviewing I have modified it, I will send a new patch at soon thanks Lijun Ou >> The Hisilicon Network Substem(hns) is a long term evolution IP which is >> supposed to be used in Hisilicon ICT SoC. RoCE is a feature of hns. >> The driver for Hisilicon RoCE engine is a platform driver. >> The driver will support mulitple versions of hns. Currently only "v1" >> for hip06 SOC is supported. >> >> >> Changes v1 -> v2: >> 1. adjust the formats of roce driver code by the experts reviewing >> 2. modify the bindings file with roce dts. add the attribute named >> interrput-names. >> 3. modify the way of defining port mode in hns_dsaf_main.c >> 4. move the Kconfig file into the hns directory and send it with roce >> driver code file together. >> >> >> Lijun Ou (3): >> infiniband: IB/hns: add Hisilicon RoCE support >> net: hns: add Hisilicon RoCE support >> infiniband: IB/hns: add Hisilicon RoCE support with bindings >> > > . >