Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405AbcCSLRV (ORCPT ); Sat, 19 Mar 2016 07:17:21 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:33005 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbcCSLRP (ORCPT ); Sat, 19 Mar 2016 07:17:15 -0400 Subject: Re: [PATCH 3/3] infiniband: IB/hns: add Hisilicon RoCE support with bindings To: Sergei Shtylyov , , , , , , , References: <1457692631-9290-1-git-send-email-oulijun@huawei.com> <1457692631-9290-4-git-send-email-oulijun@huawei.com> <56E2CA90.9020401@cogentembedded.com> CC: , , , , , , , , , , , From: oulijun Message-ID: <56ED349A.8060806@huawei.com> Date: Sat, 19 Mar 2016 19:14:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56E2CA90.9020401@cogentembedded.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.25.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.56ED34A4.005F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 83c68456e4eaecae4b86bf5b0e97b5a2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2111 Lines: 70 On 2016/3/11 21:39, Sergei Shtylyov wrote: > Hello. > > On 3/11/2016 1:37 PM, Lijun Ou wrote: > >> This submit add binding file and dts file. > > I see no .dts file. > >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu(Xavier) >> --- >> .../bindings/infiniband/hisilicon-hns-roce.txt | 68 ++++++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt >> >> diff --git a/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt >> new file mode 100644 >> index 0000000..8004641 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt >> @@ -0,0 +1,68 @@ >> +HiSilicon RoCE DT description >> + >> +HiSilicon RoCE engine is a part of network subsystem. >> +It works depending on other part of network wubsytem, such as, gmac and > > Subsystem. > >> +dsa fabric. >> + >> +Additional properties are described here: >> + >> +Required properties: >> +- compatible: Should contain "hisilicon,hns-roce-v1". >> +- reg: Physical base address of the roce driver and >> +length of memory mapped region. >> +- eth-handle: phandle, specifies a reference to a node >> +representing a ethernet device. >> +- dsaf-handle: phandle, specifies a reference to a node >> +representing a dsaf device. >> +- #address-cells: must be 2 >> +- #size-cells: must be 2 >> +Optional properties: >> +- dma-coherent: Present if DMA operations are coherent. >> +- interrupt-parent: the interrupt parent of this device. >> +- interrupts: should contain 32 completion event irq,1 async event irq >> +and 1 event overflow irq. > > The "interrupt-names" prop is strongly desired with some many IRQs. > >> +Example: >> + rocee@0xc4000000 { > > The node names should be generic, not implementation specific. > > [...] > > MBR, Sergei > > > . > Hi Sergei Shtylyov , thanks for reviewing I have modified it, I will send a new patch at soon thanks Lijun Ou