Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932232AbcCSL2j (ORCPT <rfc822;w@1wt.eu>);
	Sat, 19 Mar 2016 07:28:39 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:26167 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753827AbcCSL2f (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 19 Mar 2016 07:28:35 -0400
Subject: Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver
 code)
To: Parav Pandit <pandit.parav@gmail.com>
References: <CAG53R5WfQR1jJUOi1fjY=oEgsK_EAxkA9SiDPV_KHLHsmqg0BQ@mail.gmail.com>
 <56E65EFC.3030109@huawei.com>
 <CAG53R5UTc8xF4TdRJm3ASv6PQ-JxhW7vDgXpFtYqX2tz_58UeA@mail.gmail.com>
CC: "Wei Hu(Xavier)" <xavier.huwei@huawei.com>,
        Doug Ledford <dledford@redhat.com>,
        "Hefty, Sean" <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>, <davem@davemloft.net>,
        <jeffrey.t.kirsher@intel.com>, <jiri@mellanox.com>,
        Or Gerlitz <ogerlitz@mellanox.com>, <linux-rdma@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <gongyangming@huawei.com>, <xiaokun@huawei.com>,
        <tangchaofei@huawei.com>, <haifeng.wei@huawei.com>,
        <yisen.zhuang@huawei.com>, <yankejian@huawei.com>,
        <lisheng011@huawei.com>, <charles.chenxin@huawei.com>,
        <linuxarm@huawei.com>
From: oulijun <oulijun@huawei.com>
Message-ID: <56ED37C0.6090907@huawei.com>
Date: Sat, 19 Mar 2016 19:28:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <CAG53R5UTc8xF4TdRJm3ASv6PQ-JxhW7vDgXpFtYqX2tz_58UeA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.61.25.147]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020204.56ED37CE.0101,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: ab56ed8f615f89f7b95352aa6e5e8251
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 976
Lines: 27

On 2016/3/15 2:20, Parav Pandit wrote:
>>>
>>> Since SRQ is not supported in this driver version, can you keep
>>> remaining code base also to not bother about SRQ specifically
>>> poll_cq_one, modify_qp, destroy_qp etc?
>>> SRQ support can come as complete additional patch along with cmd_mask,
>>> callbacks and rest of the code.
>>>
>>> .
>> Sorry, I see your review in time.
>> Sure, SRQ is not supported in current roce driver. I have verified the function
>> for RDMA. It is not influence. For your question, we need to analyse it scientific.
>> after that, i will reply your doubt, is that ok?
> 
> Yes. No problem.
> 
> .
> 
Hi, Parav Pandit
    I have analyse and discuss with your reviewing. I considered that the srq is only the
condition branch in verbs and without independent function, so reserved it.I have delete the relative
function with srq independently.
    if delete the branch operation with srq, it feel be inconvenient to understand

thanks
Lijun Ou