Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934513AbcCSRsN (ORCPT ); Sat, 19 Mar 2016 13:48:13 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:58797 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934455AbcCSRr7 (ORCPT ); Sat, 19 Mar 2016 13:47:59 -0400 X-IronPort-AV: E=Sophos;i="5.24,361,1454972400"; d="scan'208";a="208914912" Date: Sat, 19 Mar 2016 18:47:56 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Wolfram Sang cc: linux-kernel@vger.kernel.org, Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr Subject: Re: [PATCH] scripts: coccinelle: remove check to move constants to right In-Reply-To: <20160319174625.GA3981@tetsubishi> Message-ID: References: <1458409079-4669-1-git-send-email-wsa@the-dreams.de> <20160319174625.GA3981@tetsubishi> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 24 On Sat, 19 Mar 2016, Wolfram Sang wrote: > On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > > On Sat, 19 Mar 2016, Wolfram Sang wrote: > > > > > The header mentions this check depends on personal taste. I agree. > > > Running coccicheck on patches before I apply them, this SmPL produced > > > enough false positives for me that I'd rather see it removed. > > > > An improvement is coming up, that should be more acceptable. However, > > it's being held up by the need for some bug fixes in Coccinelle. A > > release of Coccinelle is planned for the beginning of April. Perhaps > > it is just as well to just remove this version for now. > > > > Acked-by: Julia Lawall > > Thanks, Julia. If you put me on CC of the new version, I'll be happy to > test. Thanks :) julia