Message-ID: <1458416227.4228.4.camel@perches.com>
Subject: Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis
 checkpatch warning
From: Joe Perches <joe@perches.com>
To: Parth Sane <laerdevstudios@gmail.com>, gregkh@linuxfoundation.org
Cc: brcnakalin@gmail.com, shraddha.6596@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Sat, 19 Mar 2016 12:37:07 -0700
In-Reply-To: <1458412550-17021-1-git-send-email-laerdevstudios@gmail.com>
References: <1458412550-17021-1-git-send-email-laerdevstudios@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 906
Lines: 23

On Sat, 2016-03-19 at 18:35 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.

Please run your proposed patches through checkpatch.
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
[]
> @@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
> ?		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
> ?		ndata1.phy_addr[mac] = mac + 4 + 0x10;
> ?
> -		xlr_resource_init(&xlr_net1_res[mac * 2],
> -				xlr_gmac_offsets[mac + 4],
> -				xlr_gmac_irqs[mac + 4]);
> +		xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);

More typical is to avoid exceeding 80 columns
and wrap this line like:

		xlr_resource_init(&xlr_net1_res[mac * 2],
				  xlr_gmac_offsets[mac + 4],
				  xlr_gmac_irqs[mac + 4]);

Indenting the 2nd and 3rd lines with 4 tabs and 2 spaces