Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197AbcCTGth (ORCPT ); Sun, 20 Mar 2016 02:49:37 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:38082 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbcCTGtf (ORCPT ); Sun, 20 Mar 2016 02:49:35 -0400 MIME-Version: 1.0 In-Reply-To: <20160318105833.GF19428@n2100.arm.linux.org.uk> References: <1458293329-5519-1-git-send-email-acourbot@nvidia.com> <20160318105833.GF19428@n2100.arm.linux.org.uk> From: Alexandre Courbot Date: Sun, 20 Mar 2016 15:49:15 +0900 Message-ID: Subject: Re: [PATCH v2] ARM: DMA: Fix kzalloc flags in __dma_alloc To: Russell King - ARM Linux Cc: Alexandre Courbot , Marek Szyprowski , Rabin Vincent , Thierry Reding , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 22 On Fri, Mar 18, 2016 at 7:58 PM, Russell King - ARM Linux wrote: > On Fri, Mar 18, 2016 at 06:28:49PM +0900, Alexandre Courbot wrote: >> Commit 19e6e5e5392b ("ARM: 8547/1: dma-mapping: store buffer >> information") allocates a structure meant for internal buffer management >> with the GFP flags of the buffer itself. This can trigger the following >> safeguard in the slab/slub allocator: >> >> if (unlikely(flags & GFP_SLAB_BUG_MASK)) { >> pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK); >> BUG(); >> } >> >> Fix this by filtering the flags that make the slab allocator unhappy. >> >> Signed-off-by: Alexandre Courbot >> Cc: Rabin Vincent > > Looks much better than the original. Please send it to the patch system, > thanks. Just did that, thanks!