Message-ID: <1458466164.4228.21.camel@perches.com>
Subject: Re: [PATCH] staging: rtl8712: Removed copyright notice
From: Joe Perches <joe@perches.com>
To: Parth Sane <laerdevstudios@gmail.com>, gregkh@linuxfoundation.org
Cc: florian.c.schilhabel@googlemail.com, Larry.Finger@lwfinger.net,
        hemmo.nieminen@iki.fi, punitvara@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Sun, 20 Mar 2016 02:29:24 -0700
In-Reply-To: <1458444727-24017-1-git-send-email-laerdevstudios@gmail.com>
References: <1458444727-24017-1-git-send-email-laerdevstudios@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1274
Lines: 37

On Sun, 2016-03-20 at 03:32 +0000, Parth Sane wrote:
> Removed copyright notice as per checkpatch check warning.

This is not a good patch subject nor commit message.

Removing copyright is a serious thing.
You are not doing that.

You are removing a paragraph about an organization's
address that is subject to change.

Please be more thoughtful about what you are actually
doing when writing your commit subject lines and
messages.


> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> 
> ---
> ?drivers/staging/rtl8712/drv_types.h | 4 ----
> ?1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 29e47e1..ae79047 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -11,10 +11,6 @@
> ? * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> ? * more details.
> ? *
> - * You should have received a copy of the GNU General Public License along with
> - * this program; if not, write to the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
> - *
> ? * Modifications for inclusion into the Linux staging tree are
> ? * Copyright(c) 2010 Larry Finger. All rights reserved.
> ? *