Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755391AbcCTMFp (ORCPT ); Sun, 20 Mar 2016 08:05:45 -0400 Received: from www.linutronix.de ([62.245.132.108]:40650 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755206AbcCTMFo (ORCPT ); Sun, 20 Mar 2016 08:05:44 -0400 Date: Sun, 20 Mar 2016 13:04:05 +0100 (CET) From: Thomas Gleixner To: Kan Liang cc: peterz@infradead.org, ak@linux.intel.com, eranian@google.com, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 2/2] x86/perf/intel/uncore: Make Intel rapl modular In-Reply-To: <1458372050-2420-2-git-send-email-kan.liang@intel.com> Message-ID: References: <1458372050-2420-1-git-send-email-kan.liang@intel.com> <1458372050-2420-2-git-send-email-kan.liang@intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 360 Lines: 15 On Sat, 19 Mar 2016, kan.liang@intel.com wrote: > > +static struct notifier_block rapl_cpu_nb = { > + .notifier_call = rapl_cpu_notifier, Hmm. Missed that in the first round. That lacks .priority = CPU_PRI_PERF + 1, because the driver needs to migrate its stuff away before the core code gets notified about the cpu going down. Thanks, tglx