Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755404AbcCTMZx (ORCPT ); Sun, 20 Mar 2016 08:25:53 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:24007 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755227AbcCTMZo (ORCPT ); Sun, 20 Mar 2016 08:25:44 -0400 X-IronPort-AV: E=Sophos;i="5.24,365,1454972400"; d="scan'208";a="209032258" Date: Sun, 20 Mar 2016 13:25:28 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Vaishali Thakkar cc: mmarek@suse.com, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr, nm@ti.com, julia.lawall@lip6.fr Subject: Re: [PATCH] Coccinelle: setup_timer: Add space in front of parentheses In-Reply-To: <1458451652-5933-1-git-send-email-vaishali.thakkar@oracle.com> Message-ID: References: <1458451652-5933-1-git-send-email-vaishali.thakkar@oracle.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 43 On Sun, 20 Mar 2016, Vaishali Thakkar wrote: > Add space in front of the offending parentheses to silent the > parse error for older Coccinelle versions. This makes the rule > usable with all Coccinelle versions. > > Reported-by: Nishanth Menon > Signed-off-by: Vaishali Thakkar Acked-by: Julia Lawall > --- > scripts/coccinelle/api/setup_timer.cocci | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/coccinelle/api/setup_timer.cocci b/scripts/coccinelle/api/setup_timer.cocci > index 8ee0ac3..eb6bd9e 100644 > --- a/scripts/coccinelle/api/setup_timer.cocci > +++ b/scripts/coccinelle/api/setup_timer.cocci > @@ -106,7 +106,7 @@ position j0, j1, j2; > @match_function_and_data_after_init_timer_context > depends on !patch && > !match_immediate_function_data_after_init_timer_context && > -(context || org || report)@ > + (context || org || report)@ > expression a, b, e1, e2, e3, e4, e5; > position j0, j1, j2; > @@ > @@ -127,7 +127,7 @@ position j0, j1, j2; > @r3_context depends on !patch && > !match_immediate_function_data_after_init_timer_context && > !match_function_and_data_after_init_timer_context && > -(context || org || report)@ > + (context || org || report)@ > expression c, e6, e7; > position r1.p; > position j0, j1; > -- > 2.1.4 > >