Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907AbcCTO7S (ORCPT ); Sun, 20 Mar 2016 10:59:18 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34155 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755600AbcCTO7Q (ORCPT ); Sun, 20 Mar 2016 10:59:16 -0400 Subject: Re: [PATCH] staging: rtl8712: Removed FSF address warning Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: multipart/signed; boundary="Apple-Mail=_B274376D-72C5-4EC0-A78E-B8B720362687"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.6b2 From: Parth Sane In-Reply-To: <56EEB302.3050903@lwfinger.net> Date: Sun, 20 Mar 2016 20:28:58 +0530 Cc: gregkh@linuxfoundation.org, florian.c.schilhabel@googlemail.com, amitoj1606@gmail.com, luisbg@osg.samsung.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Message-Id: References: <1458482397-1599-1-git-send-email-laerdevstudios@gmail.com> <56EEB302.3050903@lwfinger.net> To: Larry Finger X-Mailer: Apple Mail (2.3112) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3013 Lines: 76 --Apple-Mail=_B274376D-72C5-4EC0-A78E-B8B720362687 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On 20-Mar-2016, at 7:56 PM, Larry Finger = wrote: >=20 > On 03/20/2016 08:59 AM, Parth Sane wrote: >> Removed checkpatch warning caused by FSF address block >> Signed-off-by: Parth Sane >> --- >> drivers/staging/rtl8712/hal_init.c | 4 ---- >> 1 file changed, 4 deletions(-) >=20 > Now you have at least 3 different patches all with the same subject! = How is the maintainer supposed to keep them separate? Patchworks will = replace each of them with the next one having the same title. >=20 > A better way would be to create a multiple-part set of patches with = the subject containing the name of the file being "fixed". >=20 > Note that this warning was added to checkpatch.pl well after the = driver was added to the staging tree. In fact, if this warning had been = present then, the FSF address would have been removed. >=20 > I consider this type of patch to be of minimal value; however, if you = do not remove this warning, then someone else will. Thus, you should = repackage these changes. By my count, there are 94 files containing this = information. Dropping them as one set of patches might be too many at = once. I would split them into groups of 13 files in one batch, 14 in the = next, then 15, 16, 17, and finally 19, then each group will also be = distinguishable. >=20 > If GregKH wants it done differently, he will let us know. >=20 > Larry >=20 Hi, It has been pointed out to me that I should send patch sets. I will be = doing so. So please ignore the earlier sent patches except the = parenthesis patch. Its been a pleasure to work with such a helpful community and hope to do = do more in the future. Regards, Parth Sane --Apple-Mail=_B274376D-72C5-4EC0-A78E-B8B720362687 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJW7rqzAAoJEOzxm4XTqyFiEFsP/26FNxCgCDIsNsvvH4OKw4fA 8lXwmPLR/EQGy1oBcpsMq77vhszLDpGG/msZJUdjy1jKEImsvpr1xNdf4G1kSrLP NWklMGI6E6K/rmMyR4ConQSe86JyxzL/VWSnBilQ3sBbBmpv7GExEZn9vlFWET1R 1CatnkhBSUwh2/bbG8SiEZcGUQdICke2v+ZGzXlwpCjmvMniJ7UfL62Lqcv5ShIJ vTxGaiUEOEyy3vBCTZMxuVjZyUudmbt95utp1xEzA9+xFcERjiyeTM2RuPhaVXHA 3gnByckXT2MexHiYQV7woK1SFbc7pebLBylMwf8qRAkiFymBReVJvhDnuuFAtK+2 cyFmWKcK8RYTLKx77FAD3N1PH8W29bB6KFUVB/RN/Q6TAnp+mrz6Sv72VQo9cg4n bn/NTNECH85XvrM437NDkSU3CUphwMpE2/8nXiFCTUclyINiEx+7gDmCxVLutehq u/Gh1mZDqTV/YAywe8nb1LjrxnJf0v6f2YuBpi9ttCxLNkiHH8d3Mf3jtO6lXXA/ abYPxrnAdiTGnNY9GgR0wn6dOgGViKNuIEST4IWoZC+S7zAe1t0usp2ay3N88A3r LZ0YpkusbrMv4ROC/J9MEGnhsjxuFkM51/UTBXLySwF1yNSp3+iu5MjX9lKeFA8U bj79m6gmEZVc3fRjTvL+ =vKor -----END PGP SIGNATURE----- --Apple-Mail=_B274376D-72C5-4EC0-A78E-B8B720362687--