Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935AbcCTPvm (ORCPT ); Sun, 20 Mar 2016 11:51:42 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34379 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbcCTPve (ORCPT ); Sun, 20 Mar 2016 11:51:34 -0400 Subject: Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: multipart/signed; boundary="Apple-Mail=_D0C70D05-C982-49CC-AEDC-E15CC7416A10"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.6b2 From: Parth Sane In-Reply-To: <1458488880.4228.37.camel@perches.com> Date: Sun, 20 Mar 2016 21:21:26 +0530 Cc: Greg KH , Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, luisbg@osg.samsung.com, "open list:STAGING SUBSYSTEM" , linux-kernel@vger.kernel.org, amitoj1606@gmail.com Message-Id: <0EF3C6FE-993D-4661-9595-8135ADEF1488@gmail.com> References: <1458484408-2237-1-git-send-email-laerdevstudios@gmail.com> <1458488880.4228.37.camel@perches.com> To: Joe Perches X-Mailer: Apple Mail (2.3112) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3151 Lines: 90 --Apple-Mail=_D0C70D05-C982-49CC-AEDC-E15CC7416A10 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 20-Mar-2016, at 9:18 PM, Joe Perches wrote: >=20 > On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote: >> Fixed multiple parenthesis alignment warnings. >> Signed-off-by: Parth Sane >=20 > Please always add a blank line after your changelog and > before your "Signed-off-by:" line >=20 >> diff --git a/drivers/staging/rtl8712/hal_init.c = b/drivers/staging/rtl8712/hal_init.c > [] >> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter = *padapter) >> 0x0000ffff); >> memcpy(ppayload, ptr, dump_imem_sz); >> r8712_write_mem(padapter, RTL8712_DMA_VOQ, >> - dump_imem_sz + TXDESC_SIZE, >> + dump_imem_sz + TXDESC_SIZE, >> (u8 *)ptx_desc); >=20 > Please align all lines of multi-line statements. >=20 > checkpatch is a stupid little script. > You have to make sure your own patches are sensible. >=20 > There are several things you should read and > understand in the Documentation directory. >=20 > Documentation/CodingStyle > Documentation/SubmittingPatches > Documentation/SubmitChecklist >=20 > Fixing checkpatch messages is sometimes a decent > way to understand this process, but the patches > that can be generated fixing these messages tend > to have low overall value. >=20 > After doing a few of these, please move on to > some part of the kernel that interests you and > submit new code or start to fix actual defects. >=20 > Maybe if you are interested in wireless drivers, > buy a NIC that isn't supported by the mac80211 > drivers and adapt the existing staging driver for > that variant. >=20 > Code, test, validate, submit, repeat... >=20 Hi, I=E2=80=99m first trying my hands at easy stuff before I actually move = on to more difficult stuff. I will surely look in that direction. Thanks = for your valuable inputs. Regards, Parth Sane --Apple-Mail=_D0C70D05-C982-49CC-AEDC-E15CC7416A10 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJW7sb+AAoJEOzxm4XTqyFiou8P/3/E7lAzyZc9ntTzC9N0130k IYq4LwaVU8q203PM7y+HnfCh7PjtNu5SWBt1PAMswYFNq35Xo+PO5svoEFmRLX6j oBkYWAMbW13wHwsSOJJevkd3uWAhtqDIiYpChw+8u1KWl8GNA1AIJmLnBtAWV/ys 88MLV0BgGX83JxZlLETV4LAmHK0ZU85j52cP/X2wIcjAEk0WKmKioEn5/4MeuP+u wj70gvD5oe98/5M5nIBjcaJ9YSpCTmKU4Hevr2G97E9E7Tb6guViY3Kccd6H30o2 ndrdCJp+xNFSDxjxWCgRzokvlaZaPPhJpcjKzgclDw1AyPZvuy4Un97jP2fPMUx6 BpA/6GWiCyNmvOMsMpyhGSjxEw6bxvswsW/pPyFMSa0uODHNwLnea2z3VR6h8Dxp jNgt6cSNeNZlwyOZYPZrlHBqgvluzXIOXibgpeHplje/aPLLqNwUfAdVtNqsnjCF sdblSn+CsxrNc7Lh+d1uMcKxPpdWTaqUejhIoNSYAOQEHjfL5I97NH7U6l6/rwZ/ mJgTlQ7HflDkJueCB0HGtOFz5MwUPjbTN1tP+zzeQB8aV8TOdNRGiuGd0C9Jqr8w OkKxgoTQoQ5Ao/9tEa56R7269zEihyCbvaY5yrF2d/N5XYUQNRZRht9IIlr9HUnL OglIKxRK3WTyaSyQc1yT =yCAF -----END PGP SIGNATURE----- --Apple-Mail=_D0C70D05-C982-49CC-AEDC-E15CC7416A10--