Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbcCTQtm (ORCPT ); Sun, 20 Mar 2016 12:49:42 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:36847 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbcCTQtf (ORCPT ); Sun, 20 Mar 2016 12:49:35 -0400 Subject: Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: multipart/signed; boundary="Apple-Mail=_3B3F27CB-B616-4958-A10D-EAE3F5B9A2B9"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.6b2 From: Parth Sane In-Reply-To: Date: Sun, 20 Mar 2016 22:19:26 +0530 Cc: Greg KH , luisbg@osg.samsung.com, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, florian.c.schilhabel@googlemail.com, "open list:STAGING SUBSYSTEM" , Joe Perches Message-Id: <6FFE6E69-08F3-4ED9-8026-E5F5E0401F91@gmail.com> References: <1458484408-2237-1-git-send-email-laerdevstudios@gmail.com> <1458488880.4228.37.camel@perches.com> <0EF3C6FE-993D-4661-9595-8135ADEF1488@gmail.com> To: Roger H Newell X-Mailer: Apple Mail (2.3112) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4665 Lines: 124 --Apple-Mail=_3B3F27CB-B616-4958-A10D-EAE3F5B9A2B9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 20-Mar-2016, at 10:03 PM, Roger H Newell = wrote: >=20 >=20 > On Mar 20, 2016 1:21 PM, "Parth Sane" = wrote: > > > > > > > On 20-Mar-2016, at 9:18 PM, Joe Perches wrote: > > > > > > On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote: > > >> Fixed multiple parenthesis alignment warnings. > > >> Signed-off-by: Parth Sane > > > > > > Please always add a blank line after your changelog and > > > before your "Signed-off-by:" line > > > > > >> diff --git a/drivers/staging/rtl8712/hal_init.c = b/drivers/staging/rtl8712/hal_init.c > > > [] > > >> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter = *padapter) > > >> 0x0000ffff); > > >> memcpy(ppayload, ptr, dump_imem_sz); > > >> r8712_write_mem(padapter, RTL8712_DMA_VOQ, > > >> - dump_imem_sz + TXDESC_SIZE, > > >> + dump_imem_sz + TXDESC_SIZE, > > >> (u8 *)ptx_desc); > > > > > > Please align all lines of multi-line statements. > > > > > > checkpatch is a stupid little script. > > > You have to make sure your own patches are sensible. > > > > > > There are several things you should read and > > > understand in the Documentation directory. > > > > > > Documentation/CodingStyle > > > Documentation/SubmittingPatches > > > Documentation/SubmitChecklist > > > > > > Fixing checkpatch messages is sometimes a decent > > > way to understand this process, but the patches > > > that can be generated fixing these messages tend > > > to have low overall value. > > > > > > After doing a few of these, please move on to > > > some part of the kernel that interests you and > > > submit new code or start to fix actual defects. > > > > > > Maybe if you are interested in wireless drivers, > > > buy a NIC that isn't supported by the mac80211 > > > drivers and adapt the existing staging driver for > > > that variant. > > > > > > Code, test, validate, submit, repeat... > > > > > Hi, > > I=E2=80=99m first trying my hands at easy stuff before I actually = move on to more difficult stuff. I will surely look in that direction. = Thanks for your valuable inputs. > > Regards, > > Parth Sane > > > > _______________________________________________ > > devel mailing list > > devel@linuxdriverproject.org > > = http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel > > >=20 > www.kernelnewbies.org is an excellent resource for getting started. = Check out the first patch tutorial, it walks you through all the basics = of creating and sending a properly formated patch. You're better off = learning to do it right the first time, if its not right the patch = simply won't be accepted and you'll have to redo it anyway. Take some = time to go through the tutorial I mentioned. Good luck >=20 > Roger H. Newell >=20 Hi Roger, Thanks for your comments. I=E2=80=99ve correctly submitted a patchset = for the multiple FSF notices, maybe you can comment if its any good?. = I=E2=80=99m through the rough patch and now understand the process now = quite fairly. I did checkout kernelnewbies.org before I submitted the patch, but alas = I needed some practical XP. Regards, Parth Sane --Apple-Mail=_3B3F27CB-B616-4958-A10D-EAE3F5B9A2B9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJW7tSXAAoJEOzxm4XTqyFimMwP/2wPsi+JG0vwUeccAEp5otFJ rwDnmbaF5sh+ecKqRUl6+dhr7AVvCd3eACGh9q2goC9PBvg1VS+Lx+LHjmz56zov p1rc9q4FisHB+HhXzCjR2narase/wM5sJI6uZ5e+3A6lJ1hYE6zCeG5RkMxm2CgF xGpoYnFznm+Thvz1cJkJ/oUZdggUs04lMV6meAXP9GeF9mQ7I6UoKRdE8GpuGoJZ qpoU+hbZB4/RdNwRdnnMGyXM26lUFonE0RXre787K270OJtRz+Ej5v1+9R5MRAbw yfpwf92sqCWcX970UScjzfL/ET0wptCQbUyzQJKMI3as3v6bFAd7yxqLAamVsalc cAXqNaeX2bh110e31SJLPD35sglqh9tgkz/ZEZYlQAvxv+j8Wz4u7mPKzkPRjwmL b81z+KI0m1BxiU0w3Xj/6cmdN4hGnE2u9dooexW9UNqpddHOX0B4VMr7cs6Q1EWL dh9mmTfzbOsWEZyIEo5EpbRIVBDipiOFveZ7lEilx0gGhu1CFhOOUKkMvI9RJqaE xDSZq51ZioUnRHP0weYX381UndEx3wXZbb8AnQXvST+Gmn+8bj1zvbP+kkWUmO+J s/7V8nnFEjGPd2w+ZyAbQIYD98WMDuS3qIZtIlbq3gOIekHP3rLQU+1hZO3bL8aC HEE5sZVwmcNB9lY0wH1p =x1qk -----END PGP SIGNATURE----- --Apple-Mail=_3B3F27CB-B616-4958-A10D-EAE3F5B9A2B9--