Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230AbcCTRb3 (ORCPT ); Sun, 20 Mar 2016 13:31:29 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:58053 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbcCTRb2 (ORCPT ); Sun, 20 Mar 2016 13:31:28 -0400 Date: Sun, 20 Mar 2016 13:31:22 -0400 (EDT) Message-Id: <20160320.133122.908035685889835834.davem@davemloft.net> To: ddecotig@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nikolay@cumulusnetworks.com, mst@redhat.com, ben@decadent.org.uk, jeffrey.t.kirsher@intel.com, decot@googlers.com, nicolas.dichtel@6wind.com, andrew@lunn.ch, hadarh@mellanox.com, ecree@solarflare.com, john.r.fastabend@intel.com, herbert@gondor.apana.org.au, tgraf@suug.ch, daniel@iogearbox.net, chamaken@gmail.com, fw@strlen.de, dh.herrmann@gmail.com Subject: Re: [PATCH v1 0/2] basic ioctl support for netlink sockets From: David Miller In-Reply-To: <1458259436-85275-1-git-send-email-ddecotig@gmail.com> References: <1458259436-85275-1-git-send-email-ddecotig@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 20 Mar 2016 10:31:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 404 Lines: 10 From: David Decotigny Date: Thu, 17 Mar 2016 17:03:54 -0700 > This removes the requirement that ethtool be tied to the support > of a specific L3 protocol, also updates a comment. You're adding an ioctl handler to netlink sockets, and it is not at all apparent to me how this influences ethtool handling at all. Therefore you have to explain this here and in your commit message.