Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751126AbcCTTN6 (ORCPT ); Sun, 20 Mar 2016 15:13:58 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:34462 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbcCTTNs (ORCPT ); Sun, 20 Mar 2016 15:13:48 -0400 MIME-Version: 1.0 In-Reply-To: <20160320190016.GD17997@ZenIV.linux.org.uk> References: <1458499278-1516-1-git-send-email-kirill.shutemov@linux.intel.com> <1458499278-1516-2-git-send-email-kirill.shutemov@linux.intel.com> <20160320190016.GD17997@ZenIV.linux.org.uk> Date: Sun, 20 Mar 2016 12:13:47 -0700 X-Google-Sender-Auth: A1b6iWBZXL8KOwnEYnEQoh5eVdI Message-ID: Subject: Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros From: Linus Torvalds To: Al Viro Cc: "Kirill A. Shutemov" , Christoph Lameter , Linux Kernel Mailing List , Andrew Morton , linux-fsdevel , Matthew Wilcox , Vineet Gupta , linux-mm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 13 On Sun, Mar 20, 2016 at 12:00 PM, Al Viro wrote: >> >> It doesn't help legibility or testing, so let's just do it in one big go. > > Might make sense splitting it by the thing being removed, though - easier > to visually verify that it's doing the right thing when all replacements > are of the same sort... Yeah, that might indeed make each patch easier to read, and if something goes wrong (which looks unlikely, but hey, shit happens), it also makes it easier to see just what went wrong. Linus