Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751111AbcCTTeS (ORCPT ); Sun, 20 Mar 2016 15:34:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:37640 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbcCTTeM (ORCPT ); Sun, 20 Mar 2016 15:34:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,367,1455004800"; d="scan'208";a="937933088" Date: Sun, 20 Mar 2016 22:34:07 +0300 From: "Kirill A. Shutemov" To: Linus Torvalds Cc: Al Viro , Christoph Lameter , Linux Kernel Mailing List , Andrew Morton , linux-fsdevel , Matthew Wilcox , Vineet Gupta , linux-mm Subject: Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros Message-ID: <20160320193407.GB1907@black.fi.intel.com> References: <1458499278-1516-1-git-send-email-kirill.shutemov@linux.intel.com> <1458499278-1516-2-git-send-email-kirill.shutemov@linux.intel.com> <20160320190016.GD17997@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 18 On Sun, Mar 20, 2016 at 12:13:47PM -0700, Linus Torvalds wrote: > On Sun, Mar 20, 2016 at 12:00 PM, Al Viro wrote: > >> > >> It doesn't help legibility or testing, so let's just do it in one big go. > > > > Might make sense splitting it by the thing being removed, though - easier > > to visually verify that it's doing the right thing when all replacements > > are of the same sort... > > Yeah, that might indeed make each patch easier to read, and if > something goes wrong (which looks unlikely, but hey, shit happens), it > also makes it easier to see just what went wrong. Hm. Okay. Re-split this way would take some time. I'll post updated patchset tomorrow. -- Kirill A. Shutemov