Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbcCTWVm (ORCPT ); Sun, 20 Mar 2016 18:21:42 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:34725 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbcCTWVg (ORCPT ); Sun, 20 Mar 2016 18:21:36 -0400 Date: Sun, 20 Mar 2016 15:21:27 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Linus Torvalds cc: "Kirill A. Shutemov" , Stephen Rothwell , Al Viro , Christoph Lameter , Linux Kernel Mailing List , Andrew Morton , linux-fsdevel , Matthew Wilcox , Vineet Gupta , linux-mm Subject: Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release} macros In-Reply-To: Message-ID: References: <1458499278-1516-1-git-send-email-kirill.shutemov@linux.intel.com> <1458499278-1516-2-git-send-email-kirill.shutemov@linux.intel.com> <20160320190016.GD17997@ZenIV.linux.org.uk> <20160320193407.GB1907@black.fi.intel.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 31 On Sun, 20 Mar 2016, Linus Torvalds wrote: > On Sun, Mar 20, 2016 at 12:34 PM, Kirill A. Shutemov > wrote: > > > > Hm. Okay. Re-split this way would take some time. I'll post updated > > patchset tomorrow. > > Oh, I was assuming this was automated with coccinelle or at least some > simple shell scripting.. > > Generally, for things like this, automation really is great. > > In fact, I like it when people attach the scripts to the commit > message, further clarifying exactly what they did (even if the end > result then often includes manual fixups for patterns that didn't > _quite_ match, or where the automated script just generated ugly > indentation or similar). Fine by me to make these changes - once upon a time I had a better grip than most of when and how to use PAGE_CACHE_blah; but have long lost it, and agree with all those who find the imaginary distinction now a drag. Just a plea, which I expect you already intend, to apply these changes either just before 4.6-rc1 or just before 4.7-rc1 (I think I'd opt for 4.6-rc1 myself), without any interim of days or months in linux-next, where a period of divergence would be quite tiresome. Holding back Kirill's 71/71 until the coast is clear just a little later. Thanks, Hugh