Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbcCTXqJ (ORCPT ); Sun, 20 Mar 2016 19:46:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:36102 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbcCTXqF (ORCPT ); Sun, 20 Mar 2016 19:46:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,368,1455004800"; d="scan'208";a="672879633" Date: Sun, 20 Mar 2016 19:46:33 -0400 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Andrew Morton , Alexander Viro , Linus Torvalds , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 69/71] vfs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros Message-ID: <20160320234633.GM23727@linux.intel.com> References: <1458499278-1516-1-git-send-email-kirill.shutemov@linux.intel.com> <1458499278-1516-70-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458499278-1516-70-git-send-email-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 167 Lines: 5 Spotted an oops: - length is PAGE_CACHE_SIZE, then the private data should be released, + length is PAG__SIZE, then the private data should be released,