Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756AbcCUHzU (ORCPT ); Mon, 21 Mar 2016 03:55:20 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38567 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbcCUHzR (ORCPT ); Mon, 21 Mar 2016 03:55:17 -0400 Subject: Re: [PATCH v4 1/2] lightnvm: add non-continuous lun target creation support Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: multipart/signed; boundary="Apple-Mail=_41201DD3-67DF-406A-A6D2-259DCB4DE5C3"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.6b2 From: =?utf-8?Q?Javier_Gonz=C3=A1lez?= In-Reply-To: Date: Mon, 21 Mar 2016 08:55:12 +0100 Cc: =?utf-8?Q?Matias_Bj=C3=B8rling?= , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Message-Id: <1D7DBB06-093D-4F57-AE9F-E5EE43345532@lightnvm.io> References: <1455622089-1300-1-git-send-email-ww.tao0320@gmail.com> <35B0993C-C820-49E1-BB3A-EC3A5B2033CA@lightnvm.io> To: Wenwei Tao X-Mailer: Apple Mail (2.3112) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2339 Lines: 62 --Apple-Mail=_41201DD3-67DF-406A-A6D2-259DCB4DE5C3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Wenwei, > On 19 Mar 2016, at 13:52, Wenwei Tao wrote: >=20 > Hi Javier >=20 > Thanks for the comment. > I've been busy recently, so this letter is kind of late, hope you = don't mind. > I use the qemu-nvme you mentioned and configure the nvme device driver > follow the example, it turns out the nvme device is 1 lun, I don't > know how to configure multiple lun, so I just modify the source code > to make it multiple lun, > I'm not sure the modification is right, although it seems works, but > for sake of safe I also use null_blk driver to debug this patch too. > It turns out the target creation fail is due to wrong return value > judgement in rrpc_luns_init(). Multiple LUN support can be found on this branch [1]. We are running tests; we will merge it into master soon. You are welcome to use it and send a pull-request if you see that something is missing. Please note the new options for LightNVM on top of the hw/block/nvme.c [1]https://github.com/OpenChannelSSD/qemu-nvme/tree/wl_sim Javier --Apple-Mail=_41201DD3-67DF-406A-A6D2-259DCB4DE5C3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJW76jhAAoJEGMfBTt1mRjK6nUP/2D3a3kwWO86fIqOjdp3OV1z bwDCEase6mK5WzXi12/wf0YzuU8WV4YlPan2FeCUirOMSM4HmEZjO4htNlgy3nmV DyapWlyzvefzV/rgC6rEhsNOLo2/ACqGHRhd9pi8sYlt1gJK4KtQN5lXP3Qu6LMb 7S5H5g4Gd691FxZKjBVQPZo28OKb5KlHWAqV5sifRVw8t3JeLANOqFBf4bMB5XJi 8R022v7rxHPo8zD0M7Qa48UsYbrYtdwyYdIKLPcOFloAN8hhV8H6VDg9ApQfWKUx exhRJdQ4zpnOE/qVaFCp5GrpmlV9rRPxDEqQVOIhCp5NmKurxHL+O4nk2IvCIHTj jG33NlNiDML+mnwaRAoJc2OIUxsTYXBPuIPd1ohwyRKuYchSWGV6aMGIilUPadi5 S+sK4Qe69FZThIA4Pe6m366zizqFMIfSR0x/f10TTL7pibE/XjC1QeaSf8q/+vSE 7qqmxZHIqo3tX6q3Bb9LZTA2wpY2fAyQ1tjf9fPY0uayZWCVAoYd5FjuWo/bY8DL NJHiWtN59Nic6iFqiUvAmhb/WICI9jN/e18vZVkRCbqKEaZpSP4JWCi4RJNmkDHe K3Funf6xpQwwVgi3IyAlMS/DJvHttryOx71Id+Y/ic4woVTBC+I9lr9iN0OXSIQh C57VwDtmVWnmks7jQnqH =XoN2 -----END PGP SIGNATURE----- --Apple-Mail=_41201DD3-67DF-406A-A6D2-259DCB4DE5C3--