Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753332AbcCUIQ6 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Mar 2016 04:16:58 -0400
Received: from mail-ob0-f194.google.com ([209.85.214.194]:35641 "EHLO
	mail-ob0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753092AbcCUIQz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Mar 2016 04:16:55 -0400
MIME-Version: 1.0
X-Originating-IP: [217.173.44.24]
In-Reply-To: <20160321052808.GH17997@ZenIV.linux.org.uk>
References: <1458205323-25685-1-git-send-email-miklos@szeredi.hu>
	<20160321052808.GH17997@ZenIV.linux.org.uk>
Date: Mon, 21 Mar 2016 09:16:55 +0100
Message-ID: <CAJfpegtm0V3qMwnDzi_k+Ppx8KK5wpEs_SWZ0nkKth2yuDiRqg@mail.gmail.com>
Subject: Re: [PATCH 1/4] vfs: add file_dentry()
From: Miklos Szeredi <miklos@szeredi.hu>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
        David Howells <dhowells@redhat.com>,
        Goldwyn Rodrigues <rgoldwyn@suse.com>,
        Trond Myklebust <trond.myklebust@primarydata.com>,
        stable@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
        Daniel Axtens <dja@axtens.net>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1387
Lines: 34

On Mon, Mar 21, 2016 at 6:28 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Thu, Mar 17, 2016 at 10:02:00AM +0100, Miklos Szeredi wrote:
>> Add a new helper, file_dentry() [*], to get the filesystem's own dentry
>> from the file.  This simply compares file_inode(file->f_path.dentry) to
>> file_inode(file) and if they are equal returns file->f_path.dentry (this is
>> the common, non-overlayfs case).
>>
>> In the uncommon case (regular file on overlayfs) it will call into
>> overlayfs's ->d_native_dentry() to get the underlying dentry matching
>> file_inode(file).
>
> What's wrong with making ovl_dentry_real() an instance of optional
> ->d_real() method and having a flag (DCACHE_OP_REAL) controlling its
> calls?  With d_real(dentry) returning either that or dentry itself,
> and file_dentry(file) being simply d_real(file->f_path.dentry)...
>
> Why do we need to look at the inode at all?  d_set_d_op() dereferences
> ->d_op anyway, as well as setting ->d_flags, so there's no extra cost
> there, and "test bit in ->d_flags + branch not taken" is all it would
> cost in normal case...

Checking DCACHE_OP_REAL insted of inode would be fine.

But d_real() needs inode as well.  Consider the case where

 1) file opened on lower layer
 2) copied up
 3) file_dentry() called

d_real(file->f_path.dentry) would return the upper dentry but that's
not what we want.

Thanks,
Miklos