Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbcCUIX3 (ORCPT ); Mon, 21 Mar 2016 04:23:29 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35039 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752957AbcCUIXZ convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2016 04:23:25 -0400 MIME-Version: 1.0 In-Reply-To: <56EC744F.90308@suse.de> References: <1458300056-6174-1-git-send-email-tomeu.vizoso@collabora.com> <56EC744F.90308@suse.de> From: Tomeu Vizoso Date: Mon, 21 Mar 2016 09:23:04 +0100 X-Google-Sender-Auth: JrklonaP8rJk-maXzIO1ujRVra0 Message-ID: Subject: Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: "linux-kernel@vger.kernel.org" , Mark Rutland , "devicetree@vger.kernel.org" , Russell King , Heiko Stuebner , Pawel Moll , Ian Campbell , Rob Herring , Kumar Gala , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" , Giuseppe Cavallaro Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 49 On 18 March 2016 at 22:34, Andreas Färber wrote: > Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso: >> So the dwmac device manages to probe again. >> >> Signed-off-by: Tomeu Vizoso >> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression") >> --- >> arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi >> index 1ece66f3e162..4ba7ddecb478 100644 >> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi >> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi >> @@ -101,6 +101,14 @@ >> snps,reset-delays-us = <0 10000 30000>; >> rx_delay = <0x10>; >> tx_delay = <0x30>; >> + mdio0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "snps,dwmac-mdio"; >> + ethphy1: ethernet-phy@1 { >> + reg = <1>; >> + }; >> + }; > > This is a) ugly for lack of white lines in between, b) unnecessary since > this is being fixed in the stmmac driver where it will benefit more than > just this one SoM. So is this redundant information, or just not necessary with the present kernel driver because of some assumption in its current implementation? Thanks, Tomeu > Regards, > Andreas > >> }; >> >> &i2c0 { > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)