Date: Mon, 21 Mar 2016 15:54:23 +0530
From: Pratyush Anand <panand@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com,
        Dave.Martin@arm.com, hanjun.guo@linaro.org, james.morse@arm.com,
        yang.shi@linaro.org, gregkh@linuxfoundation.org, marc.zyngier@arm.com,
        richard@nod.at, wangnan0@huawei.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is
 wrongly triggered in irq
Message-ID: <20160321102423.GB15150@dhcppc6.redhat.com>
References: <1458549470-124791-1-git-send-email-hekuang@huawei.com>
 <1458549470-124791-2-git-send-email-hekuang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458549470-124791-2-git-send-email-hekuang@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 580
Lines: 13

On 21/03/2016:08:37:50 AM, He Kuang wrote:
> On arm64, watchpoint handler enables single-step to bypass the next
> instruction for not recursive enter. If an irq is triggered right
> after the watchpoint, a single-step will be wrongly triggered in irq
> handler, which causes the watchpoint address not stepped over and
> system hang.

Does patch [1] resolves this issue as well? I hope it should. Patch[1] has still
not been sent for review. Your test result will be helpful.

~Pratyush

[1] https://github.com/pratyushanand/linux/commit/7623c8099ac22eaa00e7e0f52430f7a4bd154652