Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802AbcCULCf (ORCPT ); Mon, 21 Mar 2016 07:02:35 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:48217 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbcCULC2 convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2016 07:02:28 -0400 From: Alexey Brodkin To: "daniel@ffwll.ch" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "airlied@linux.ie" Subject: Re: [PATCH 1/3] drm: introduce drm_connector_plug_all() helper Thread-Topic: [PATCH 1/3] drm: introduce drm_connector_plug_all() helper Thread-Index: AQHRgP06emIB6aRta0S+7Z5tETFnsZ9fbvSAgABBAYCAAMpTAIADNUAA Date: Mon, 21 Mar 2016 11:02:21 +0000 Message-ID: <1458558140.12775.8.camel@synopsys.com> References: <1458295304-5528-1-git-send-email-abrodkin@synopsys.com> <1458295304-5528-2-git-send-email-abrodkin@synopsys.com> <20160318180609.GM14170@phenom.ffwll.local> <1458338329.2994.8.camel@synopsys.com> <20160319100258.GP14170@phenom.ffwll.local> In-Reply-To: <20160319100258.GP14170@phenom.ffwll.local> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.125] Content-Type: text/plain; charset="utf-7" Content-ID: <3BB1B0729573DF4AA744DF181DB37AE8@internal.synopsys.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3727 Lines: 62 Hi Daniel, On Sat, 2016-03-19 at 11:02 +-0100, Daniel Vetter wrote: +AD4- On Fri, Mar 18, 2016 at 09:58:49PM +-0000, Alexey Brodkin wrote: +AD4- +AD4- +AD4- +AD4- Hi Daniel, +AD4- +AD4- +AD4- +AD4- On Fri, 2016-03-18 at 19:06 +-0100, Daniel Vetter wrote: +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- On Fri, Mar 18, 2016 at 01:01:42PM +-0300, Alexey Brodkin wrote: +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- As a pair to already existing drm+AF8-connector+AF8-unplug+AF8-all() we're adding +AD4- +AD4- +AD4- +AD4- generic implementation of what is already done in some drivers. +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- Once this helper is implemented we'll be ready to switch existing +AD4- +AD4- +AD4- +AD4- driver-specific implementations with generic one. +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- Signed-off-by: Alexey Brodkin +ADw-abrodkin+AEA-synopsys.com+AD4- +AD4- +AD4- +AD4- +AD4- Cc: Daniel Vetter +ADw-daniel+AEA-ffwll.ch+AD4- +AD4- +AD4- +AD4- +AD4- Cc: David Airlie +ADw-airlied+AEA-linux.ie+AD4- +AD4- +AD4- +AD4- +AD4- --- +AD4- +AD4- +AD4- +AD4- +AKA-drivers/gpu/drm/drm+AF8-crtc.c +AHw- 44 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-- +AD4- +AD4- +AD4- +AD4- +AKA-drivers/gpu/drm/drm+AF8-drv.c+AKAAoAB8AKAAoA-3 +-+-- +AD4- +AD4- +AD4- +AD4- +AKA-include/drm/drm+AF8-crtc.h+AKAAoACgAKAAoAB8AKAAoA-3 +-+-- +AD4- +AD4- +AD4- +AD4- +AKA-3 files changed, 47 insertions(+-), 3 deletions(-) +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- diff --git a/drivers/gpu/drm/drm+AF8-crtc.c b/drivers/gpu/drm/drm+AF8-crtc.c +AD4- +AD4- +AD4- +AD4- index 65258ac..ce27420 100644 +AD4- +AD4- +AD4- +AD4- --- a/drivers/gpu/drm/drm+AF8-crtc.c +AD4- +AD4- +AD4- +AD4- +-+-+- b/drivers/gpu/drm/drm+AF8-crtc.c +AD4- +AD4- +AD4- +AD4- +AEAAQA- -1080,6 +-1080,46 +AEAAQA- void drm+AF8-connector+AF8-unregister(struct drm+AF8-connector +ACo-connector) +AD4- +AD4- +AD4- +AD4- +AKAAfQ- +AD4- +AD4- +AD4- +AD4- +AKA-EXPORT+AF8-SYMBOL(drm+AF8-connector+AF8-unregister)+ADs- +AD4- +AD4- +AD4- +AD4- +AKA- +AD4- +AD4- +AD4- +AD4- +-/+ACoAKg- +AD4- +AD4- +AD4- +AD4- +- +ACo- drm+AF8-connector+AF8-plug+AF8-all - register connector userspace interfaces +AD4- +AD4- +AD4- +AD4- +- +ACo- +AEA-dev: drm device +AD4- +AD4- +AD4- +AD4- +- +ACo- +AD4- +AD4- +AD4- +AD4- +- +ACo- This function registers all connector userspace interfaces in sysfs. Should +AD4- +AD4- +AD4- +AD4- +- +ACo- be call when the device is disconnected, e.g. from an usb driver's +AD4- +AD4- +AD4- Still talks about disconnect +ADs--) Please also mention that this just calls +AD4- +AD4- +AD4- drm+AF8-connector+AF8-register() exactly like this including () to generate a +AD4- +AD4- +AD4- kerneldoc hyperlink. +AD4- +AD4- Well I intentionally left in description of drm+AF8-connector+AF8-register+AF8-all(): +AD4- +AD4- +ACI-Should be call when the device is disconnected, e.g. from an usb driver's +AD4- +AD4- +AKA--+AD4-connect callback.+ACI- +AD4- You use +ACI-disconnected+ACI- for connecting stuff. That doesn't make sense to me +AD4- at all - register+AF8-all is for when you want to publish something, not for +AD4- unpublishing when the device disappears. Or maybe this is a case of lost +AD4- in translation, and you mean something else? Let me try to explain what I meant. We execute -+AD4-connect() callback of USB device when USB device is still in +ACI-disconnected+ACI- state (well at least that was my thought). And only when that -+AD4-connect() callback succeeds we're entering +ACI-connected+ACI- state. Probably above sentence is not correct. Then could you please help me with correct wording of comment to+AKA-drm+AF8-connector+AF8-register+AF8-all()? -Alexey