Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895AbcCULhg (ORCPT ); Mon, 21 Mar 2016 07:37:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:39563 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754403AbcCULh1 (ORCPT ); Mon, 21 Mar 2016 07:37:27 -0400 Date: Mon, 21 Mar 2016 11:37:19 +0000 From: Mel Gorman To: js1304@gmail.com Cc: Andrew Morton , Rik van Riel , Johannes Weiner , Laura Abbott , Minchan Kim , Marek Szyprowski , Michal Nazarewicz , "Aneesh Kumar K.V" , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Joonsoo Kim Subject: Re: [PATCH 1/6] mm/page_alloc: fix same zone check in __pageblock_pfn_to_page() Message-ID: <20160321113719.GM28876@suse.de> References: <1457940697-2278-1-git-send-email-iamjoonsoo.kim@lge.com> <1457940697-2278-2-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1457940697-2278-2-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 20 On Mon, Mar 14, 2016 at 04:31:32PM +0900, js1304@gmail.com wrote: > From: Joonsoo Kim > > There is a system that node's pfn are overlapped like as following. > > -----pfn--------> > N0 N1 N2 N0 N1 N2 > > Therefore, we need to care this overlapping when iterating pfn range. > > In __pageblock_pfn_to_page(), there is a check for this but it's > not sufficient. This check cannot distinguish the case that zone id > is the same but node id is different. This patch fixes it. > I think you may be mixing up page_zone_id with page_zonenum. -- Mel Gorman SUSE Labs