Date: Mon, 21 Mar 2016 07:45:55 -0500
From: Rob Herring <robh@kernel.org>
To: Andreas Dannenberg <dannenberg@ti.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT
 bindings
Message-ID: <20160321124555.GA12693@rob-hp-laptop>
References: <1458343678-4086-1-git-send-email-dannenberg@ti.com>
 <1458343678-4086-2-git-send-email-dannenberg@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458343678-4086-2-git-send-email-dannenberg@ti.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1731
Lines: 41

On Fri, Mar 18, 2016 at 06:27:57PM -0500, Andreas Dannenberg wrote:
> The Texas Instruments TAS5720L/M device is a high-efficiency mono
> Class-D audio power amplifier optimized for high transient power
> capability to use the dynamic power headroom of small loudspeakers.
> Its digital time division multiplexed (TDM) interface enables up to
> 16 devices to share the same bus.
> 
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
>  .../devicetree/bindings/sound/tas5720.txt          | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b/Documentation/devicetree/bindings/sound/tas5720.txt
> new file mode 100644
> index 0000000..3775a3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tas5720.txt
> @@ -0,0 +1,37 @@
> +Texas Instruments TAS5720 Mono Audio amplifier
> +
> +The TAS5720 serial control bus communicates through the I2C protocol only.
> +
> +Required properties:
> +
> +- compatible : "ti,tas5720"
> +- reg : I2C slave address
> +
> +Optional properties:
> +
> +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> +- interrupts-extended : reference to a GPIO pin connected to the TAS5720
> +                        FAULTZ pin for error reporting purposes

There's no point in having interrupts-extended here with a single 
interrupt. It is fine to use, but really that's outside the scope of 
this binding. So I'd just document "interrupts" here as that is what 
most docs do, and that implies interrupts-extended could be used.

Rob