Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755840AbcCUMxj (ORCPT ); Mon, 21 Mar 2016 08:53:39 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33860 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754162AbcCUMxh (ORCPT ); Mon, 21 Mar 2016 08:53:37 -0400 Date: Mon, 21 Mar 2016 13:53:35 +0100 From: Michal Hocko To: "Kirill A. Shutemov" Cc: Andrew Morton , Alexander Viro , Linus Torvalds , Christoph Lameter , Matthew Wilcox , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: drop PAGE_CACHE_* and page_cache_{get,release} definition Message-ID: <20160321125335.GE23066@dhcp22.suse.cz> References: <1458561998-126622-1-git-send-email-kirill.shutemov@linux.intel.com> <1458561998-126622-4-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458561998-126622-4-git-send-email-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1329 Lines: 47 On Mon 21-03-16 15:06:38, Kirill A. Shutemov wrote: > All users gone. We can remove these macros. > > Signed-off-by: Kirill A. Shutemov \o/ Acked-by: Michal Hocko Thanks! > --- > include/linux/pagemap.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index b3fc0370c14f..7e1ab155c67c 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -86,21 +86,6 @@ static inline void mapping_set_gfp_mask(struct address_space *m, gfp_t mask) > (__force unsigned long)mask; > } > > -/* > - * The page cache can be done in larger chunks than > - * one page, because it allows for more efficient > - * throughput (it can then be mapped into user > - * space in smaller chunks for same flexibility). > - * > - * Or rather, it _will_ be done in larger chunks. > - */ > -#define PAGE_CACHE_SHIFT PAGE_SHIFT > -#define PAGE_CACHE_SIZE PAGE_SIZE > -#define PAGE_CACHE_MASK PAGE_MASK > -#define PAGE_CACHE_ALIGN(addr) (((addr)+PAGE_CACHE_SIZE-1)&PAGE_CACHE_MASK) > - > -#define page_cache_get(page) get_page(page) > -#define page_cache_release(page) put_page(page) > void release_pages(struct page **pages, int nr, bool cold); > > /* > -- > 2.7.0 -- Michal Hocko SUSE Labs