Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755574AbcCUNUI (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Mar 2016 09:20:08 -0400
Received: from mga09.intel.com ([134.134.136.24]:39335 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754400AbcCUNUF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Mar 2016 09:20:05 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,372,1455004800"; 
   d="scan'208";a="938357170"
Date: Mon, 21 Mar 2016 21:18:16 +0800
From: kbuild test robot <lkp@intel.com>
To: Alexandre Bounine <alexandre.bounine@idt.com>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
        Alexandre Bounine <alexandre.bounine@idt.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        Aurelien Jacquiot <a-jacquiot@ti.com>,
        Andre van Herk <andre.van.herk@prodrive-technologies.com>,
        Barry Wood <barry.wood@idt.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] rapidio: fix ifnullfree.cocci warnings
Message-ID: <20160321131816.GA8270@xian.intel.com>
References: <201603212151.0G3jM1ue%fengguang.wu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458560281-17420-1-git-send-email-alexandre.bounine@idt.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: fengguang.wu@intel.com
X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1432
Lines: 40

drivers/rapidio/rio_cm.c:1401:4-9: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/rapidio/rio_cm.c:1408:4-9: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Alexandre Bounine <alexandre.bounine@idt.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 rio_cm.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -1397,15 +1397,15 @@ static void riocm_ch_free(struct kref *r
 
 	if (ch->rx_ring.inuse_cnt) {
 		for (i = 0; i < RIOCM_RX_RING_SIZE; i++) {
-			if (ch->rx_ring.inuse[i] != NULL)
-				kfree(ch->rx_ring.inuse[i]);
+			kfree(ch->rx_ring.inuse[i]);
 		}
 	}
 
 	if (ch->rx_ring.count)
 		for (i = 0; i < RIOCM_RX_RING_SIZE; i++)
-			if (ch->rx_ring.buf[i] != NULL)
-				kfree(ch->rx_ring.buf[i]);
+		{
+			kfree(ch->rx_ring.buf[i]);
+		}
 
 	complete(&ch->comp_close);
 }