Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756116AbcCUOG2 (ORCPT ); Mon, 21 Mar 2016 10:06:28 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:54414 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752482AbcCUOGZ (ORCPT ); Mon, 21 Mar 2016 10:06:25 -0400 Date: Mon, 21 Mar 2016 09:06:03 -0500 From: Andreas Dannenberg To: Rob Herring CC: , , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Subject: Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Message-ID: <20160321140603.GN20025@borg.dal.design.ti.com> References: <1458343678-4086-1-git-send-email-dannenberg@ti.com> <1458343678-4086-2-git-send-email-dannenberg@ti.com> <20160321124555.GA12693@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160321124555.GA12693@rob-hp-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 21 On Mon, Mar 21, 2016 at 07:45:55AM -0500, Rob Herring wrote: > > +Optional properties: > > + > > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry > > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog > > +- interrupts-extended : reference to a GPIO pin connected to the TAS5720 > > + FAULTZ pin for error reporting purposes > > There's no point in having interrupts-extended here with a single > interrupt. It is fine to use, but really that's outside the scope of > this binding. So I'd just document "interrupts" here as that is what > most docs do, and that implies interrupts-extended could be used. Hi Rob, Good point. Will remove it for v2. Regards, -- Andreas Dannenberg Texas Instruments Inc