Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756159AbcCUO5r (ORCPT ); Mon, 21 Mar 2016 10:57:47 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:33349 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755746AbcCUO5o (ORCPT ); Mon, 21 Mar 2016 10:57:44 -0400 Date: Mon, 21 Mar 2016 14:57:41 +0000 From: Matt Fleming To: hpa@zytor.com, eranian@google.com, linux-kernel@vger.kernel.org, tony.luck@intel.com, brgerst@gmail.com, peterz@infradead.org, bp@alien8.de, tglx@linutronix.de, vikas.shivappa@linux.intel.com, dsahern@gmail.com, dvlasenk@redhat.com, jolsa@redhat.com, luto@amacapital.net, mingo@kernel.org, acme@redhat.com, torvalds@linux-foundation.org, namhyung@kernel.org, vincent.weaver@maine.edu, alexander.shishkin@linux.intel.com Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/urgent] perf/x86/cqm: Fix CQM handling of grouping events into a cache_group Message-ID: <20160321145741.GC11676@codeblueprint.co.uk> References: <1457652732-4499-2-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 20 On Mon, 21 Mar, at 02:51:29AM, tip-bot for Vikas Shivappa wrote: > Commit-ID: a223c1c7ab4cc64537dc4b911f760d851683768a > Gitweb: http://git.kernel.org/tip/a223c1c7ab4cc64537dc4b911f760d851683768a > Author: Vikas Shivappa > AuthorDate: Thu, 10 Mar 2016 15:32:07 -0800 > Committer: Ingo Molnar > CommitDate: Mon, 21 Mar 2016 09:08:18 +0100 > > perf/x86/cqm: Fix CQM handling of grouping events into a cache_group > > Currently CQM (cache quality of service monitoring) is grouping all > events belonging to same PID to use one RMID. However its not counting > all of these different events. Hence we end up with a count of zero > for all events other than the group leader. The reason that was done originally was because reporting for all events in a group led to duplicate values, since you'd be emitting the same RMID value multiple times. Is this no longer a problem?