Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756529AbcCUO7m (ORCPT ); Mon, 21 Mar 2016 10:59:42 -0400 Received: from exsmtp03.microchip.com ([198.175.253.49]:19125 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755982AbcCUO7k (ORCPT ); Mon, 21 Mar 2016 10:59:40 -0400 From: To: , , , CC: , , , , Subject: RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Thread-Topic: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Thread-Index: AQHRgpVrRdyRALUs2keEkS6lXb+y9Z9jaG8AgACVAqA= Date: Mon, 21 Mar 2016 14:59:38 +0000 Message-ID: <9235D6609DB808459E95D78E17F2E43D404CBFF1@CHN-SV-EXMX02.mchp-main.com> References: <1458470636-18986-1-git-send-email-geert@linux-m68k.org> <56EF2B44.9040807@roeck-us.net> In-Reply-To: <56EF2B44.9040807@roeck-us.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.76.4] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2LExlmG007219 Content-Length: 943 Lines: 23 > -----Original Message----- > From: Guenter Roeck [mailto:linux@roeck-us.net] > Sent: Sunday, March 20, 2016 6:59 PM > To: Geert Uytterhoeven; Woojung Huh - C21699; UNGLinuxDriver; David S. > Miller > Cc: Rafael J. Wysocki; netdev@vger.kernel.org; linux-usb@vger.kernel.org; > linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef > CONFIG_PM > > Not that it matters anymore since David reverted the original patch, > but my reason for not sending a similar patch was that I wasn't sure > if .runtime_auto should be accessed from drivers in the first place, > or if there is some logical problem with the code. > Because driver can enable/disable autosuspend by usb_enable_autosuspend() and usb_disable_autosuspend(), it would be nice to have helper to find out autosuspend status. The code path was to utilize autosuspend power saving, when it is enabled. Woojung