Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756245AbcCUPDB (ORCPT ); Mon, 21 Mar 2016 11:03:01 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:60672 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755895AbcCUPC7 (ORCPT ); Mon, 21 Mar 2016 11:02:59 -0400 Date: Mon, 21 Mar 2016 11:02:58 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Rajesh Bhagat cc: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , "mathias.nyman@intel.com" , Sriram Dash Subject: RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 501 Lines: 11 On Mon, 21 Mar 2016, Rajesh Bhagat wrote: > I agree to your point. Actually the intent was to check the return status of reset_device which > is currently being ignored. I encountered the reset_device failure case in resume operation (STR) > which is increasing the time of resume and causing unexpected crashes if return value is not checked. > > Do you agree it should be checked here? If yes, I can rework this patch. I don't know. You should ask the xHCI maintainter, Mathias. Alan Stern