Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756674AbcCUPgq (ORCPT ); Mon, 21 Mar 2016 11:36:46 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:32968 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756197AbcCUPgn (ORCPT ); Mon, 21 Mar 2016 11:36:43 -0400 MIME-Version: 1.0 In-Reply-To: <20160321124043.GA26873@rob-hp-laptop> References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> <20160321124043.GA26873@rob-hp-laptop> Date: Mon, 21 Mar 2016 16:36:42 +0100 Message-ID: Subject: Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue From: Joachim Eastwood To: Rob Herring Cc: Chen-Yu Tsai , Alexandre TORGUE , Maxime Coquelin , Giuseppe Cavallaro , netdev , devicetree , linux-kernel , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 33 On 21 March 2016 at 13:40, Rob Herring wrote: > On Sat, Mar 19, 2016 at 12:00:22AM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >> wrote: >> > +- clocks: Must contain a phandle for each entry in clock-names. >> > +- clock-names: Should be "stmmaceth" for the host clock. > > This doesn't sound like the clock input signal name... > >> > + Should be "tx-clk" for the MAC TX clock. >> > + Should be "rx-clk" for the MAC RX clock. > > How can other DWMAC blocks not have these clocks? The glue can't really > add these clocks. It could combine them into one or a new version of > DWMAC could have a different number of clock inputs. So if there is > variation here, then some of the bindings are probably wrong. I guess > the only change I'm suggesting is possibly moving these into common > binding doc. The LPC18xx implementation probably have these clocks as well but the LPC1850 user manual only documents the main clock. Someone with access to the IP block doc from Synopsys should be able to check which clocks the MAC really needs. Rockchip bindings have two clocks named "mac_clk_rx" and "mac_clk_tx". These are probably the same as stm32 needs so maybe use these names and move them into the main doc and update the rockchip binding. regards, Joachim Eastwood