Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756804AbcCUQsx (ORCPT ); Mon, 21 Mar 2016 12:48:53 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41487 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756064AbcCUQsw (ORCPT ); Mon, 21 Mar 2016 12:48:52 -0400 Date: Mon, 21 Mar 2016 17:48:44 +0100 From: Peter Zijlstra To: Chris Metcalf Cc: Russell King , Thomas Gleixner , Aaron Tomlin , Ingo Molnar , Andrew Morton , Daniel Thompson , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus Message-ID: <20160321164843.GD6344@twins.programming.kicks-ass.net> References: <1458147733-29338-1-git-send-email-cmetcalf@mellanox.com> <1458147733-29338-5-git-send-email-cmetcalf@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458147733-29338-5-git-send-email-cmetcalf@mellanox.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 26 The below annotates the two most used idle functions on x86 --- a/arch/x86/kernel/acpi/cstate.c +++ b/arch/x86/kernel/acpi/cstate.c @@ -152,7 +152,7 @@ int acpi_processor_ffh_cstate_probe(unsi } EXPORT_SYMBOL_GPL(acpi_processor_ffh_cstate_probe); -void acpi_processor_ffh_cstate_enter(struct acpi_processor_cx *cx) +__cpuidle void acpi_processor_ffh_cstate_enter(struct acpi_processor_cx *cx) { unsigned int cpu = smp_processor_id(); struct cstate_entry *percpu_entry; --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -725,7 +725,7 @@ static struct cpuidle_state avn_cstates[ * * Must be called under local_irq_disable(). */ -static int intel_idle(struct cpuidle_device *dev, +__cpuidle static int intel_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { unsigned long ecx = 1; /* break on interrupt flag */