Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756832AbcCURVS (ORCPT ); Mon, 21 Mar 2016 13:21:18 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:35710 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755732AbcCURVR (ORCPT ); Mon, 21 Mar 2016 13:21:17 -0400 MIME-Version: 1.0 In-Reply-To: <1458394270-21938-1-git-send-email-vz@mleia.com> References: <1458394270-21938-1-git-send-email-vz@mleia.com> Date: Mon, 21 Mar 2016 10:21:16 -0700 Message-ID: Subject: Re: [PATCH] remoteproc: st: fix check of syscon_regmap_lookup_by_phandle() return value From: Bjorn Andersson To: Vladimir Zapolskiy Cc: Ohad Ben-Cohen , Ludovic Barre , Lee Jones , lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 375 Lines: 11 On Sat, Mar 19, 2016 at 6:31 AM, Vladimir Zapolskiy wrote: > syscon_regmap_lookup_by_phandle() returns either a valid pointer to > struct regmap or ERR_PTR() error value, check for NULL is invalid and > on error path may lead to oops, the change corrects the check. > > Signed-off-by: Vladimir Zapolskiy Applied, with Lee's ack. Thanks, Bjorn