Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757238AbcCUR3i (ORCPT ); Mon, 21 Mar 2016 13:29:38 -0400 Received: from resqmta-ch2-10v.sys.comcast.net ([69.252.207.42]:53843 "EHLO resqmta-ch2-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756823AbcCUR3g (ORCPT ); Mon, 21 Mar 2016 13:29:36 -0400 Date: Mon, 21 Mar 2016 12:29:34 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: "Kirill A. Shutemov" cc: Andrew Morton , Alexander Viro , Linus Torvalds , Matthew Wilcox , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache_{get,release} macros In-Reply-To: <20160321170655.GA141158@black.fi.intel.com> Message-ID: References: <1458561998-126622-1-git-send-email-kirill.shutemov@linux.intel.com> <20160321163404.GA141069@black.fi.intel.com> <20160321170655.GA141158@black.fi.intel.com> Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 250 Lines: 7 On Mon, 21 Mar 2016, Kirill A. Shutemov wrote: > We do have two page sizes in the page cache. It's the only option to get > transparent huge pages transparent. Should then not PAGE_CACHE_SIZE take a page parameter and return the correct page size?