Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757607AbcCURos (ORCPT ); Mon, 21 Mar 2016 13:44:48 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36293 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757534AbcCURok (ORCPT ); Mon, 21 Mar 2016 13:44:40 -0400 MIME-Version: 1.0 In-Reply-To: <20160320.133122.908035685889835834.davem@davemloft.net> References: <1458259436-85275-1-git-send-email-ddecotig@gmail.com> <20160320.133122.908035685889835834.davem@davemloft.net> From: David Decotigny Date: Mon, 21 Mar 2016 10:43:58 -0700 X-Google-Sender-Auth: BCeuD9kxWSjssiUAjtTJLt-HvC4 Message-ID: Subject: Re: [PATCH v1 0/2] basic ioctl support for netlink sockets To: David Miller Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , nikolay@cumulusnetworks.com, "Michael S. Tsirkin" , Ben Hutchings , Jeff Kirsher , nicolas.dichtel@6wind.com, andrew@lunn.ch, hadarh@mellanox.com, ecree@solarflare.com, john.r.fastabend@intel.com, Herbert Xu , tgraf@suug.ch, daniel@iogearbox.net, chamaken@gmail.com, fw@strlen.de, dh.herrmann@gmail.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 774 Lines: 16 sent updated version. commit description should have the details. what we are doing there is mimic what some others are doing, such as udp.c: when returning -ENOIOCTLCMD, net/core would fallback to dev_ioctl, which implements the NIC driver ioctls, which include ethtool ioctl. On Sun, Mar 20, 2016 at 10:31 AM, David Miller wrote: > From: David Decotigny > Date: Thu, 17 Mar 2016 17:03:54 -0700 > >> This removes the requirement that ethtool be tied to the support >> of a specific L3 protocol, also updates a comment. > > You're adding an ioctl handler to netlink sockets, and it is not > at all apparent to me how this influences ethtool handling at all. > > Therefore you have to explain this here and in your commit message.