Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757656AbcCUSOd (ORCPT ); Mon, 21 Mar 2016 14:14:33 -0400 Received: from mga11.intel.com ([192.55.52.93]:18713 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756223AbcCUSOc (ORCPT ); Mon, 21 Mar 2016 14:14:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,372,1455004800"; d="scan'208";a="941998243" Date: Mon, 21 Mar 2016 11:14:37 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Matt Fleming cc: hpa@zytor.com, eranian@google.com, linux-kernel@vger.kernel.org, tony.luck@intel.com, brgerst@gmail.com, peterz@infradead.org, bp@alien8.de, tglx@linutronix.de, vikas.shivappa@linux.intel.com, dsahern@gmail.com, dvlasenk@redhat.com, jolsa@redhat.com, luto@amacapital.net, mingo@kernel.org, acme@redhat.com, torvalds@linux-foundation.org, namhyung@kernel.org, vincent.weaver@maine.edu, alexander.shishkin@linux.intel.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/urgent] perf/x86/cqm: Fix CQM handling of grouping events into a cache_group In-Reply-To: <20160321145741.GC11676@codeblueprint.co.uk> Message-ID: References: <1457652732-4499-2-git-send-email-vikas.shivappa@linux.intel.com> <20160321145741.GC11676@codeblueprint.co.uk> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 40 On Mon, 21 Mar 2016, Matt Fleming wrote: > On Mon, 21 Mar, at 02:51:29AM, tip-bot for Vikas Shivappa wrote: >> Commit-ID: a223c1c7ab4cc64537dc4b911f760d851683768a >> Gitweb: http://git.kernel.org/tip/a223c1c7ab4cc64537dc4b911f760d851683768a >> Author: Vikas Shivappa >> AuthorDate: Thu, 10 Mar 2016 15:32:07 -0800 >> Committer: Ingo Molnar >> CommitDate: Mon, 21 Mar 2016 09:08:18 +0100 >> >> perf/x86/cqm: Fix CQM handling of grouping events into a cache_group >> >> Currently CQM (cache quality of service monitoring) is grouping all >> events belonging to same PID to use one RMID. However its not counting >> all of these different events. Hence we end up with a count of zero >> for all events other than the group leader. > > The reason that was done originally was because reporting for all events > in a group led to duplicate values, since you'd be emitting the same > RMID value multiple times. > > Is this no longer a problem? Before MBM , the below condition was never hit because we had only one event ? - if (a->hw.target == b->hw.target) + if (a->hw.target == b->hw.target) { + b->hw.is_group_event = true; We are trying to address this for cases where different MBM(local or total) and cqm events are grouped into one RMID. Which is the case which led to duplicate values ? Thanks, Vikas >