Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757631AbcCUSRd (ORCPT ); Mon, 21 Mar 2016 14:17:33 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:54556 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756863AbcCUSRb (ORCPT ); Mon, 21 Mar 2016 14:17:31 -0400 Date: Mon, 21 Mar 2016 11:17:26 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , axboe@kernel.dk, torvalds@linux-foundation.org, bfields@fieldses.org, tytso@mit.edu, martin.petersen@oracle.com, linux-api@vger.kernel.org, david@fromorbit.com, linux-kernel@vger.kernel.org, shane.seymour@hpe.com, linux-fsdevel@vger.kernel.org, jlayton@poochiereds.net, akpm@linux-foundation.org Subject: Re: [PATCH 3/3] block: implement (some of) fallocate for block devices Message-ID: <20160321181726.GA10892@infradead.org> References: <20160315194221.30093.70506.stgit@birch.djwong.org> <20160315194244.30093.6483.stgit@birch.djwong.org> <20160321153827.GA27230@infradead.org> <20160321175235.GA5812@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160321175235.GA5812@birch.djwong.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 502 Lines: 9 On Mon, Mar 21, 2016 at 10:52:35AM -0700, Darrick J. Wong wrote: > > I don't really understand the comment. But I think you'd be much > > I don't know of a block device primitive that corresponds to the "default" > mode of fallocate, as documented in the manpage (i.e. mode == 0). I agree > that the whole thing could be simplified in the manner you point out below. SCSI allows 'anchoring' blocks, which is pretty similar to a normal fallocate, but we don't support anchoring blocks in Linux yet.