Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757473AbcCUTSq (ORCPT ); Mon, 21 Mar 2016 15:18:46 -0400 Received: from exsmtp01.microchip.com ([198.175.253.37]:20634 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757211AbcCUTSo convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2016 15:18:44 -0400 From: To: , CC: , , , , , , , , Subject: RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Thread-Topic: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Thread-Index: AQHRgpVrRdyRALUs2keEkS6lXb+y9Z9kCZOAgABqqICAACvLAIAADd2A//+N0tA= Date: Mon, 21 Mar 2016 18:42:06 +0000 Message-ID: <9235D6609DB808459E95D78E17F2E43D404CC166@CHN-SV-EXMX02.mchp-main.com> References: <1458581670.9609.5.camel@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.76.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 567 Lines: 11 > But this leaves open the issue that querying the device too often will > prevent it from going into autosuspend. It seems to me that the best > way to deal with this is to make sure that the autosuspend timeout is > shorter than the interal between queries, not to make the querying > conditional on !runtime_auto. Short autosuspend timeout can affect performance. For instance our experiments showed that shorter than 10sec timeout made Ethernet performance degrade because of wakeup delays. So, just putting shorter timeout may have some side effects. Woojung