Date: Mon, 21 Mar 2016 21:19:17 +0100
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tina Ruchandani <ruchandani.tina@gmail.com>, y2038@lists.linaro.org,
        linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: nosy: Replace timeval with timespec64
Message-ID: <20160321211917.198f4f03@kant>
In-Reply-To: <3432361.tg4OvfJSmN@wuerfel>
References: <20160321055911.GA98166@localhost>
	<3432361.tg4OvfJSmN@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1277
Lines: 30

On Mar 21 Arnd Bergmann wrote:
> On Sunday 20 March 2016 22:59:11 Tina Ruchandani wrote:
> > 'struct timeval' uses a 32 bit field for its 'seconds' value which
> > will overflow in year 2038 and beyond. This patch replaces the use
> > of timeval in nosy.c with timespec64 which doesn't suffer from y2038
> > issue. The code is correct as is - since it is only using the
> > microseconds portion of timeval. However, this patch does the
> > replacement as part of a larger effort to remove all instances of
> > 'struct timeval' from the kernel (that would help identify cases
> > where the code is actually broken).
> > 
> > Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
> > ---
> >  drivers/firewire/nosy.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)  
> 
> The patch looks correct to me, but it seems the same one has
> just been merged into mainline Linux on Saturday (the patch
> was posted back in October).
> 
> commit 2ae4b6b20e2004dccf80d804ae52b073377c2f5b
[...]

No, Amitoj's patch from October changed nosy.c::packet_irq_hander, whereas
Tina' patch changes nosy.c::bus_reset_irq_handler.  IOW the new patch
completes what the former patch (and us reviewers) missed.
-- 
Stefan Richter
-======----- --== =-=-=
http://arcgraph.de/sr/