Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757971AbcCUVFK (ORCPT ); Mon, 21 Mar 2016 17:05:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54010 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753736AbcCUVFJ (ORCPT ); Mon, 21 Mar 2016 17:05:09 -0400 Date: Mon, 21 Mar 2016 17:05:06 -0400 From: Greg KH To: Daeseok Youn Cc: lidza.louina@gmail.com, markh@compro.net, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct Message-ID: <20160321210506.GD9749@kroah.com> References: <20160314042831.GA5760@SEL-JYOUN-D1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160314042831.GA5760@SEL-JYOUN-D1> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 262 Lines: 9 On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote: > For using tty_alloc_driver, SerialDriver has to be pointer type. Yes, but you aren't calling tty_alloc_driver, so this patch totally breaks the working code :( Please be more careful... greg k-h