Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757984AbcCUVFh (ORCPT ); Mon, 21 Mar 2016 17:05:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54012 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbcCUVFf (ORCPT ); Mon, 21 Mar 2016 17:05:35 -0400 Date: Mon, 21 Mar 2016 17:05:32 -0400 From: Greg KH To: Daeseok Youn Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc Message-ID: <20160321210532.GE9749@kroah.com> References: <20160314042900.GA6179@SEL-JYOUN-D1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160314042900.GA6179@SEL-JYOUN-D1> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 390 Lines: 13 On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote: > the tty_alloc_driver() can allocate memory for ttys and termios. > And also it can release allocated memory easly with using > put_tty_driver(). > > Signed-off-by: Daeseok Youn But you broke the driver in the previous patch, you can't do that, each patch has to be 'stand-alone'. thanks, greg k-h