Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754758AbcCUWFb (ORCPT ); Mon, 21 Mar 2016 18:05:31 -0400 Received: from one.firstfloor.org ([193.170.194.197]:38760 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbcCUWFa (ORCPT ); Mon, 21 Mar 2016 18:05:30 -0400 Date: Mon, 21 Mar 2016 23:05:28 +0100 From: Andi Kleen To: Andy Lutomirski Cc: Andi Kleen , "linux-kernel@vger.kernel.org" , X86 ML , Andi Kleen Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Message-ID: <20160321220528.GE5083@two.firstfloor.org> References: <1458576969-13309-1-git-send-email-andi@firstfloor.org> <1458576969-13309-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 567 Lines: 17 > Please add a patch before this one that renames gs to gsbase. This is > unreadable as is. I investigated this now, and it's not straight forward because on 32bit ->gs is actually gsindex, not gsbase. So with a straight rename you would end up with index in base on 32bit, which would be confusing. Perhaps this could be cleaned up at some point, switching 32bit to use ->gsindex. But not right now, seems somewhat risky, and I don't want to make it part of this patch kit. FWIW I think it's readable. -Andi -- ak@linux.intel.com -- Speaking for myself only.