Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754311AbcCUWJI (ORCPT ); Mon, 21 Mar 2016 18:09:08 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:35434 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbcCUWJH (ORCPT ); Mon, 21 Mar 2016 18:09:07 -0400 MIME-Version: 1.0 In-Reply-To: <20160321220528.GE5083@two.firstfloor.org> References: <1458576969-13309-1-git-send-email-andi@firstfloor.org> <1458576969-13309-3-git-send-email-andi@firstfloor.org> <20160321220528.GE5083@two.firstfloor.org> From: Andy Lutomirski Date: Mon, 21 Mar 2016 15:08:46 -0700 Message-ID: Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base To: Andi Kleen Cc: "linux-kernel@vger.kernel.org" , X86 ML , Andi Kleen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 655 Lines: 17 On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen wrote: >> Please add a patch before this one that renames gs to gsbase. This is >> unreadable as is. > > I investigated this now, and it's not straight forward because on 32bit > ->gs is actually gsindex, not gsbase. So with a straight rename you > would end up with index in base on 32bit, which would be confusing. > I would take this inconsistency as a reason why this needs to be fixed before any further changes are made. The variables should be called "gsbase" and "gsindex", full stop. It's not particularly risky -- we could even compare the generated code if we cared. --Andy