Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755338AbcCUWPw (ORCPT ); Mon, 21 Mar 2016 18:15:52 -0400 Received: from one.firstfloor.org ([193.170.194.197]:38840 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbcCUWPv (ORCPT ); Mon, 21 Mar 2016 18:15:51 -0400 Date: Mon, 21 Mar 2016 23:15:49 +0100 From: Andi Kleen To: Andy Lutomirski Cc: Andi Kleen , "linux-kernel@vger.kernel.org" , X86 ML , Andi Kleen Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Message-ID: <20160321221549.GG5083@two.firstfloor.org> References: <1458576969-13309-1-git-send-email-andi@firstfloor.org> <1458576969-13309-3-git-send-email-andi@firstfloor.org> <20160321220528.GE5083@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 31 On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote: > On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen wrote: > >> Please add a patch before this one that renames gs to gsbase. This is > >> unreadable as is. > > > > I investigated this now, and it's not straight forward because on 32bit > > ->gs is actually gsindex, not gsbase. So with a straight rename you > > would end up with index in base on 32bit, which would be confusing. > > > > I would take this inconsistency as a reason why this needs to be fixed > before any further changes are made. The patchkit doesn't change anything for 32bit, so any inconsistency in 32bit is completely orthogonal. I don't see how adding a bazillion unrelated changes makes this patchkit any better. > > The variables should be called "gsbase" and "gsindex", full stop. > It's not particularly risky -- we could even compare the generated > code if we cared. Iff you can catch all the ifdefs ... I looked through the grep hits and I don't think it's straight forward. -Andi -- ak@linux.intel.com -- Speaking for myself only.