Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758101AbcCVAbk (ORCPT ); Mon, 21 Mar 2016 20:31:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37219 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbcCVAbj (ORCPT ); Mon, 21 Mar 2016 20:31:39 -0400 To: Colin King Cc: Kashyap Desai , Sumit Saxena , James Bottomley , "Martin K . Petersen" , megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] megaraid_sas: fix missing { }, nullify kbuff_arr[i] only when necessary From: "Martin K. Petersen" Organization: Oracle Corporation References: <1458493412-17103-1-git-send-email-colin.king@canonical.com> Date: Mon, 21 Mar 2016 20:31:05 -0400 In-Reply-To: <1458493412-17103-1-git-send-email-colin.king@canonical.com> (Colin King's message of "Sun, 20 Mar 2016 17:03:32 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 387 Lines: 14 >>>>> "Colin" == Colin King writes: Colin> From: Colin Ian King Fix missing { } Colin> on if statement, this change will nullify kbuff_arr[i] only where Colin> necessary as the code intended. Colin> detected using static analysis with smatch Kashyap/Sumit: Please review. Thanks! -- Martin K. Petersen Oracle Linux Engineering