Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758061AbcCVAnM (ORCPT ); Mon, 21 Mar 2016 20:43:12 -0400 Received: from gloria.sntech.de ([95.129.55.99]:48710 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754524AbcCVAnL convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2016 20:43:11 -0400 From: Heiko Stuebner To: Yakir Yang Cc: David Airlie , Mark Yao , Joonyoung Shim , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Emil Velikov Subject: Re: [RFC PATCH v1 0/4] Add Rockchip RGA support Date: Tue, 22 Mar 2016 01:42:50 +0100 Message-ID: <1867694.1mDULrSexE@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <56EFE66A.8020404@rock-chips.com> References: <1458552518-25527-1-git-send-email-ykk@rock-chips.com> <1511371.I0NIYzh3kP@diego> <56EFE66A.8020404@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1910 Lines: 54 Hi Yakir, Am Montag, 21. M?rz 2016, 20:17:46 schrieb Yakir Yang: > On 03/21/2016 07:29 PM, Heiko St?bner wrote: > > Am Montag, 21. M?rz 2016, 17:28:38 schrieb Yakir Yang: > >> This patch set would add the RGA direct rendering based 2d graphics > >> acceleration module. > > > > very cool to see that. > > ;) > > >> This patch set is based on git repository below: > >> git://people.freedesktop.org/~airlied/linux drm-next > >> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7 > >> > >> And the RGA driver is based on Exynos G2D driver, it only manages the > >> command lists received from user, so user should make the command list > >> to data and registers needed by operation to use. > >> > >> I have prepared an userspace demo application for testing: > >> https://github.com/yakir-Yang/libdrm-rockchip > >> > >> That is a rockchip libdrm library, and I have write a simple test case > >> "rockchip_rga_test" that would test the below RGA features: > >> - solid > >> - copy > >> - rotation > >> - flip > >> - window clip > >> - dithering > > > > Did you submit your libdrm changes as well? > > > > Userspace-interfaces need to be stable so the other side must also get > > accepted - even before the kernel change if I remember correctly. > > Got it, and I just saw exynos_fimg2d already landed at mainline libdrm. > But I don't find the way to submit patches to libdrm, would you like > share some helps here ;) Looking at the libdrm sources on cgit.freedesktop.org, I did not find any specific manual on submitting patches. But looking at the dri-list archive, dri-devel@lists.freedesktop.org is the right list and looking at the libdrm history it looks like Emil Velikov seems to be doing maintenance-stuff in libdrm. And as a 3rd recipient, please also include the linux-rockchip list. @Emil, please shout if I read that wrong :-) Hope that helps Heiko